Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-6411 Discovery image deleted on cluster removal #1720

Merged
merged 1 commit into from
May 21, 2021
Merged

MGMT-6411 Discovery image deleted on cluster removal #1720

merged 1 commit into from
May 21, 2021

Conversation

masayag
Copy link
Contributor

@masayag masayag commented May 12, 2021

When removing a cluster, its discovery-image should be deleted as well.

Signed-off-by: Moti Asayag [email protected]

@openshift-ci openshift-ci bot requested review from machacekondra and osherdp May 12, 2021 15:06
@rollandf
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@masayag
MGMT-6411 Discovery image deleted on cluster removal
dd9c009 
When removing a cluster, its discovery-image should be deleted as well.

Signed-off-by: Moti Asayag <[email protected]>
@rollandf
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@rollandf
Copy link

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masayag, rollandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@masayag
Copy link
Contributor Author

masayag commented May 20, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d134953 into openshift:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machacekondra machacekondra Awaiting requested review from machacekondra

@osherdp osherdp Awaiting requested review from osherdp

Assignees

@rollandf rollandf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masayag @rollandf @openshift-bot @openshift-merge-robot