Copy install_dir files to local storage directory #7
Conversation
render_files.py
Outdated
| print("Uploading file %s as object %s" % (file_path, s3_file_name)) | ||
| s3_file_name = "/{}/{}/{}".format(work_dir, cluster_id, file_name) | ||
| print("Copying file %s to %s" % (file_path, s3_file_name)) | ||
| shutil.copyfile(file_path, s3_file_name) |
There was a problem hiding this comment.
We don't need the original files, so maybe it would be more efficient to move them rather than copying. If the source and destination are on the same file system then it would mean changing a pointer rather than reading and writing actual data.
There was a problem hiding this comment.
Moving the install_dir to a directory named $cluster_id would make it more confusing though. May be symlink to the original files in install_dir?
sacharya
force-pushed
the
local_storage
branch
from
f07ffe3 to
dc777f2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, sacharya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Can one of the admins verify this patch? |
No description provided.