This repository has been archived by the owner on Oct 19, 2020. It is now read-only.
MGMT-1890 - assisted-service client should be backwards compatible #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
openshift-ci-robot
added
the
approved
|
not sure it's required since MichaelH coded it in go already
…On Sun, Aug 23, 2020, 01:40 OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *yevgeny-shnaidman
<#18#>*
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=openshift%2Fassisted-ignition-generator>
.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- OWNERS
<https://github.com/openshift/assisted-ignition-generator/blob/master/OWNERS>
[yevgeny-shnaidman]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLPP43OCUB5QDFB7TVHDP3SCBCONANCNFSM4QIKIVJA>
.
|
eranco74
reviewed
Aug 23, 2020
| @@ -37,7 +37,7 @@ | |||
| "name": "eth0", | |||
| "model": "0x0001", | |||
| "mac": "41:68:00:0e:ce:82", | |||
| "ip": "192.168.126.13", | |||
| "ip": "fe80::5054:ff:fe0e:ce92", | |||
There was a problem hiding this comment.
this is just a test file to check that we take ipv6 IP in case ipv4 is not present, the value is some jubk
|
@romfreiman let's push it now, since we don't know when MichaelH code will be pushed, especially since it is not 4.6 compliant yet |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsorya, yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.