-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] DNM : Enable evented pleg feature to default #1486
Conversation
Hello @sairameshv! Some important instructions when contributing to openshift/api: |
126e350
to
e4cb4e4
Compare
config/v1/feature_gates.go
Outdated
@@ -193,7 +193,7 @@ var ( | |||
OwningProduct: kubernetes, | |||
} | |||
|
|||
FeatureGateEventedPLEG = FeatureGateName("EventedPLEG") | |||
FeatureGateEventedPLEG = FeatureGateName("EventedPleg") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think changing this really solves the issue does it? Your intention is to enable the EventedPLEG feature at some point via turning the feature gate on in Kubelet, we've observed it has issues today with our existing configuration, how will you ensure in the future that it doesn't break customer clusters if you are enabling it?
I'm not sure why masking it now is better than digging out the root cause of the issue we are observing and working out what the incompatibility is, seems we will need to work it out as part of enabling this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoelSpeed , This change is purely part of the debugging purpose and there is no intention of masking the issue to pass the tests.
I want to enable the evented pleg feature only in either of kubelet, cri-o at once and see if I get any clue on the issue.
So, please ignore these changes until I get back with the root cause analysis !!
f87f133
to
8bcd8cd
Compare
8bcd8cd
to
1aa9b31
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sairameshv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1aa9b31
to
60030ed
Compare
60030ed
to
def731e
Compare
def731e
to
3fdba02
Compare
@sairameshv: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue has been root caused and fixed upstream - kubernetes/kubernetes#120942 |
This PR is to verify and to debug the issues if any present while running the e2e tests
cc: @harche @JoelSpeed