Bug 1548311 - Return success on depro extcred miss #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
jmrodri
suggested changes
Feb 24, 2018
pkg/broker/deprovision_subscriber.go
Outdated
| log.Error("failed to delete extracted credentials - %v", err) | ||
| err := dao.DeleteExtractedCredentials(instanceID) | ||
|
|
||
| if err != nil && strings.Contains(err.Error(), etcdKeyNotFoundContents) { |
There was a problem hiding this comment.
All the other places we do dao calls this is how we check for the not found key error:
if err != nil {
// no jobs or states to recover, this is OK.
if client.IsKeyNotFound(err) {
log.Info("No jobs to recover")
return "", nil
}
return "", err
}
The above comes from broker.go
pkg/broker/deprovision_subscriber.go
Outdated
| err := dao.DeleteExtractedCredentials(instanceID) | ||
|
|
||
| if err != nil && strings.Contains(err.Error(), etcdKeyNotFoundContents) { | ||
| log.Debugf("Attempted to delete extracted credentials, but key was not found: [%v]", instanceID) |
There was a problem hiding this comment.
Will we ever want to know this in production? That is would we want to see it at INFO level? If not, leave it at debug. Just wondering if this will be useful information or not.
There was a problem hiding this comment.
It's probably useful in production, I'll bump it up to INFO.
eriknelson
force-pushed
the
bz1548311
branch
from
0e39e73 to
de55f9a
Compare
openshift-ci-robot
added
size/XS
|
@jmrodri updated to use |
jmrodri
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #790 to master