Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user when using an old client #769

Merged
merged 1 commit into from
Feb 16, 2018

Conversation

rthallisey
Copy link
Contributor

Some good regex practice 😃 .
Sample output:

WARNING: Using client version: v3.7.0 with cluster version: v3.9.0-alpha.3

Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #752

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2018
@jmrodri jmrodri self-requested a review February 16, 2018 14:00
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS! ACK!

Tested with ORIGIN_VERSION=v3.9.0-alpha.2 ./scripts/run_latest_build.sh When using a 3.7 oc client, I get the WARNING. When using a 3.9 oc client, it works fine.

@jmrodri jmrodri merged commit eec8ce3 into openshift:master Feb 16, 2018
@rthallisey rthallisey deleted the run-latest-check branch February 16, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_latest_build.sh does not deploy console
3 participants