[MTSRE-298] Refactor integration test suite #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mayankshah1607 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mayankshah1607
changed the title
|
/retest |
1 similar comment
|
/retest |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
mayankshah1607
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mayankshah1607
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Mayank Shah <[email protected]>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/hold |
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
|
/lgtm Awesome work! |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
testify/suitelibrary for integration tests. This mechanism allows us to group theses tests into a commonintegrationTestSuiteand add proper setup and teardown for it.SetupSuiteandTeardownSuitemethods for the test suitecatalog_source_test.go,namespaces_test.go, andsubscription_test.gointo a single test with each of them as a subtest inaddon_test.gointegration/package to adapt to thesuitelibraryAddonobject declarations into re-usable fixtures infixtures_test.go, thereby removing redundantAddonobject initializationsRemoval of parallel test execution
This PR also removes parallel execution of tests because
testify/suitehas poor support for parallel test execution - stretchr/testify#187 . Running tests within a test suite in parallel causes the following problems: