Remove preserve file before calling prune_nodes #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
@ccardenosa: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aleskandro
reviewed
Nov 5, 2024
aleskandro
approved these changes
Nov 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, ccardenosa, jadhaj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
below scripys:
bash ./wipe/baremetal-lab-post-wipe-commands.sh
bash ./dns/baremetal-lab-post-dns-commands.sh
bash ./firewall/baremetal-lab-post-firewall-commands.sh
bash ./load-balancer/baremetal-lab-post-load-balancer-commands.sh
contains the following code snippet:
[ -z “${PULL_NUMBER:-}” ] &&
timeout -s 9 10m ssh “${SSHOPTS[@]}” “root@${AUX_HOST}”
test -f /var/builds/${NAMESPACE}/preserve &&
exit 0
which causes them to exit 0 early, due to the existence of preserve file, hence actual pruning will not happen
The PR propose to delete preserve file once a decision is taken to prune the cluster, before calling prune_nodes