Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster] library: prom: with-queries: load the 'metrics.txt' file from the 'testing_dir' #582

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Nov 6, 2024

No description provided.

Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kpouget. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kpouget
Copy link
Contributor Author

kpouget commented Nov 7, 2024

merging this, the sanity has been tested with #580
(I didn't verify yet that Prometheus capture with-queries is fixed though)

@kpouget kpouget merged commit 5d13472 into openshift-psap:main Nov 7, 2024
6 of 7 checks passed
@kpouget kpouget deleted the prom branch November 7, 2024 16:23
@kpouget
Copy link
Contributor Author

kpouget commented Nov 7, 2024

merging this, the sanity has been tested with #580
(I didn't verify yet that Prometheus capture with-queries is fixed though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant