Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate stable refs instead of tags #569

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Apr 12, 2022

We were force generating tags on release when we really should have done
ref.

Fix when getting multiple tags too to only pickup the right one.

Fix goreleaser generated message to point to the assets on release page

Make CI of e2e only activate on push to main, or it will get crazy on release when we push all those branches.

Generate the proper version and quay tags for each specific push on releaseyamls

Fixes #568
Fixes #573
Fixes #574

Signed-off-by: Chmouel Boudjnah [email protected]

Changes

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

@chmouel chmouel force-pushed the issue-568-fix-retriggering-the-release-ci branch from 85fbee6 to 46d0f34 Compare April 12, 2022 14:47
@chmouel chmouel marked this pull request as draft April 12, 2022 14:51
We would spin up way too many jobs on every branch on release and token
would get rate limited.

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the issue-568-fix-retriggering-the-release-ci branch from 46d0f34 to cc5b98b Compare April 12, 2022 15:00
We were force generating tags on release when we really should have done
ref.

Fix when getting multiple tags too to only pickup the right one.

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel force-pushed the issue-568-fix-retriggering-the-release-ci branch from cc5b98b to 11743c2 Compare April 13, 2022 06:04
@chmouel chmouel marked this pull request as ready for review April 13, 2022 06:04
it has been too flaky, we use the quay integration to do it since much
easier to debug when failures.

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel merged commit c378fa4 into openshift-pipelines:main Apr 13, 2022
@chmouel chmouel deleted the issue-568-fix-retriggering-the-release-ci branch April 13, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Quay.io upload has been too flaky Fix generating stable branches Fix retriggering the release CI
2 participants