Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cleanup cron to remove taskrun instead of pipelineRun #421

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

sm43
Copy link
Contributor

@sm43 sm43 commented Feb 19, 2022

pac is ran inside a taskrun now instead of pipelineRun which was
earlier. this update the cleanup cron for it.

Fixes #417

Signed-off-by: Shivam Mukhade [email protected]

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please make sure to document it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the developer guide for a bit more details.

pac is ran inside a taskrun now instead of pipelineRun which was
earlier. this update the cleanup cron for it.

Signed-off-by: Shivam Mukhade <[email protected]>
@chmouel chmouel merged commit 093c8c7 into openshift-pipelines:main Feb 21, 2022
@sm43 sm43 deleted the fix-cron branch April 4, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

cron cleanup doesn't cleanup tr but still try pr
2 participants