Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling across documentation #398

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jan 7, 2022

  • Make sure we initialize the fake kube client
  • spelling and formatting fixes in documentation

Changes

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please make sure to document it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the developer guide for a bit more details.

@chmouel
Copy link
Member Author

chmouel commented Jan 7, 2022

/retest

@chmouel chmouel merged commit e7ea177 into openshift-pipelines:main Jan 7, 2022
@chmouel chmouel deleted the spelling-install-md branch January 7, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant