Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns branch name as main if ref as refs-heads-main #392

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

sm43
Copy link
Contributor

@sm43 sm43 commented Dec 10, 2021

Closes #361
Signed-off-by: Shivam Mukhade [email protected]

Changes

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behaviour, please make sure to document it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
  • 🔎 If there is a flakyness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the developer guide for a bit more details.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #392 (8653c59) into main (69e49b6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   70.58%   70.60%   +0.02%     
==========================================
  Files          50       50              
  Lines        2587     2589       +2     
==========================================
+ Hits         1826     1828       +2     
  Misses        582      582              
  Partials      179      179              
Impacted Files Coverage Δ
pkg/formatting/vcs.go 90.90% <100.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e49b6...8653c59. Read the comment docs.

Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chmouel chmouel merged commit 0261621 into openshift-pipelines:main Dec 10, 2021
@sm43 sm43 deleted the fix-desc-cmd branch December 10, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

branch name on push refers as ref-heads-main
3 participants