Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another day another flow update #384

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Dec 8, 2021

This time as jpg since the export from flowchart break

Signed-off-by: Chmouel Boudjnah [email protected]

Changes

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behaviour, please make sure to document it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
  • 🔎 If there is a flakyness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the contribution guide
for more details.

This time as jpg since the export from flowchart break

Signed-off-by: Chmouel Boudjnah <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #384 (126eb04) into main (2c4df5c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   70.52%   70.56%   +0.03%     
==========================================
  Files          50       50              
  Lines        2565     2585      +20     
==========================================
+ Hits         1809     1824      +15     
- Misses        577      582       +5     
  Partials      179      179              
Impacted Files Coverage Δ
pkg/acl/acl.go 100.00% <0.00%> (ø)
pkg/kubeinteraction/secrets.go 55.00% <0.00%> (+14.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4df5c...126eb04. Read the comment docs.

@chmouel chmouel merged commit 44e2d06 into openshift-pipelines:main Dec 8, 2021
@chmouel chmouel deleted the update-flow branch December 8, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants