Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #380

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Dec 7, 2021

Signed-off-by: Chmouel Boudjnah [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #380 (6f65f77) into main (6156fae) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 6f65f77 differs from pull request most recent head 06f2856. Consider uploading reports for the commit 06f2856 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   70.51%   70.60%   +0.08%     
==========================================
  Files          50       50              
  Lines        2571     2582      +11     
==========================================
+ Hits         1813     1823      +10     
- Misses        580      581       +1     
  Partials      178      178              
Impacted Files Coverage Δ
pkg/pipelineascode/secret.go 92.85% <0.00%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6156fae...06f2856. Read the comment docs.

@nikhil-thomas
Copy link
Member

/lgtm

@chmouel chmouel force-pushed the pull-request-template branch 2 times, most recently from 857cfe8 to 979c17e Compare December 8, 2021 09:05
Add pre-push-hook script example

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel
Copy link
Member Author

chmouel commented Dec 8, 2021

the e2e tests seems some transitive error with github and google ko,

@chmouel chmouel merged commit 1148315 into openshift-pipelines:main Dec 8, 2021
@chmouel chmouel deleted the pull-request-template branch December 8, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants