Fixes annotation bug which used to err out on string value #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good! let's wait to have the pac cluster to come back up and test it. in the meantime any chance to update the documentation with the multiple format supported? you can maybe add a single task reference in the e2e template so we can test it too on e2e, for example : pipelinesascode.tekton.dev/task-2: "pylint" |
|
/retest |
Codecov Report
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 70.79% 70.51% -0.28%
==========================================
Files 50 50
Lines 2568 2581 +13
==========================================
+ Hits 1818 1820 +2
- Misses 573 582 +9
- Partials 177 179 +2
Continue to review full report at Codecov.
|
sm43
force-pushed
the
fix-annotation-validation
branch
from
f5c1a5c
to
8ea4292
Compare
|
/retest |
chmouel
reviewed
Dec 7, 2021
sm43
force-pushed
the
fix-annotation-validation
branch
from
8ea4292
to
cc09157
Compare
chmouel
reviewed
Dec 7, 2021
sm43
force-pushed
the
fix-annotation-validation
branch
from
cc09157
to
9452dfa
Compare
previoulsy, when the annotation are not array but a string : eg. pipelinesascode.tekton.dev/on-event: "pull_request" pac used to err out. This patch fixes that and now allows single string along with array of string. eg. ["foo", "bar"], ["foo"] or "foo" Signed-off-by: Shivam Mukhade <[email protected]>
sm43
force-pushed
the
fix-annotation-validation
branch
from
9452dfa
to
913e03b
Compare
chmouel
approved these changes
Dec 7, 2021
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previoulsy, when the annotation are not array but a string :
eg. pipelinesascode.tekton.dev/on-event: "pull_request"
pac used to err out.
This patch fixes that and now allows single string along
with array of string.
eg. ["foo", "bar"], ["foo"] or "foo"
Closes #374
Signed-off-by: Shivam Mukhade [email protected]