Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.md #370

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Update cli.md #370

merged 2 commits into from
Nov 25, 2021

Conversation

Swilvan
Copy link
Contributor

@Swilvan Swilvan commented Nov 24, 2021

I believe I've found some typo's in this document.

I believe I've found some typo's in this document.
@chmouel
Copy link
Member

chmouel commented Nov 24, 2021

/ok-to-test

Sounds good thank you but i believe we want to keep pipelinerun as pipelinerun since it's really a tekton object in this case.

@Swilvan
Copy link
Contributor Author

Swilvan commented Nov 25, 2021

/ok-to-test

Sounds good thank you but i believe we want to keep pipelinerun as pipelinerun since it's really a tekton object in this case.

oh of course, reading through this for the first time I hadn't realised that. Leaves only one typo 😉

This should reference tekton objects and not be english
@codecov-commenter
Copy link

Codecov Report

Merging #370 (8f0b6e7) into main (311f8ff) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   71.08%   70.85%   -0.23%     
==========================================
  Files          50       50              
  Lines        2545     2573      +28     
==========================================
+ Hits         1809     1823      +14     
- Misses        558      572      +14     
  Partials      178      178              
Impacted Files Coverage Δ
pkg/kubeinteraction/wait.go 0.00% <0.00%> (ø)
pkg/kubeinteraction/labels.go 0.00% <0.00%> (ø)
pkg/cmd/pipelineascode/pipelineascode.go 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311f8ff...8f0b6e7. Read the comment docs.

@chmouel
Copy link
Member

chmouel commented Nov 25, 2021

thanks a bunch 🙇🏻

@chmouel chmouel merged commit a086835 into openshift-pipelines:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants