Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Resolver #1757

Closed

Conversation

piyush-garg
Copy link
Member

This will refactor resolver to work with
multiple edge case scenarios

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

This will refactor resolver to work with
multiple edge case scenarios
@savitaashture
Copy link
Member

/test

1 similar comment
@savitaashture
Copy link
Member

/test

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 45.07042% with 78 lines in your changes missing coverage. Please review.

Project coverage is 63.57%. Comparing base (5c88f74) to head (eae0131).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/resolve/remote.go 52.04% 37 Missing and 10 partials ⚠️
pkg/matcher/annotation_tasks_install.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
- Coverage   65.11%   63.57%   -1.54%     
==========================================
  Files         174      174              
  Lines       13137    13139       +2     
==========================================
- Hits         8554     8353     -201     
- Misses       4018     4227     +209     
+ Partials      565      559       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chmouel
Copy link
Member

chmouel commented Sep 10, 2024

will take over from my own branch

@chmouel chmouel closed this Sep 10, 2024
@piyush-garg
Copy link
Member Author

/open

@piyush-garg
Copy link
Member Author

for ref, new PR #1762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants