Bump Pipelines to v0.62.1 and Gitea to v1.22.1 #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savitaashture
force-pushed
the
bump-pipeline-62.1
branch
2 times, most recently
from
1a5cae1
to
1e00f31
Compare
* Bump Pipelines v0.62.1 * Removed replaces for k8s.io * Pipeline v0.62.x removed OCI bundles so updated test yaml files from taskRef.bundle and pipelineRef.bundle to bundle resolver * Updated Dockerfile and pipelinerun yamls under .tekton from go1.21 to go1.22 * Fixed some unit tests Signed-off-by: Savita Ashture <[email protected]>
savitaashture
force-pushed
the
bump-pipeline-62.1
branch
from
1e00f31
to
d12f33a
Compare
* Fixes https://issues.redhat.com/browse/SRVKP-5914 Signed-off-by: Savita Ashture <[email protected]>
savitaashture
changed the title
|
/test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 64.63% 65.14% +0.50%
==========================================
Files 146 174 +28
Lines 11271 13131 +1860
==========================================
+ Hits 7285 8554 +1269
- Misses 3454 4013 +559
- Partials 532 564 +32 ☔ View full report in Codecov by Sentry. |
savitaashture
force-pushed
the
bump-pipeline-62.1
branch
from
5cb3552
to
62c0eeb
Compare
savitaashture
force-pushed
the
bump-pipeline-62.1
branch
from
62c0eeb
to
0a2cf4c
Compare
* After updating to go 1.22 there were some go vet issues * This commit address those Signed-off-by: Savita Ashture <[email protected]>
savitaashture
force-pushed
the
bump-pipeline-62.1
branch
from
0a2cf4c
to
a1e40f2
Compare
|
@savitaashture LGTM as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d12f33a fixes
taskRef.bundleandpipelineRef.bundleto bundle resolver ref docCommit 9fb743d fixes
Signed-off-by: Savita Ashture [email protected]
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).