-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: controller crash when provenance is set only on the global repo #1742
Merged
savitaashture
merged 2 commits into
openshift-pipelines:main
from
savitaashture:srvkp-5571
Jul 30, 2024
Merged
fix: controller crash when provenance is set only on the global repo #1742
savitaashture
merged 2 commits into
openshift-pipelines:main
from
savitaashture:srvkp-5571
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savitaashture
requested review from
enarha and
zakisk
and removed request for
enarha and
zakisk
July 23, 2024 17:42
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
+ Coverage 64.61% 64.63% +0.01%
==========================================
Files 146 146
Lines 11271 11271
==========================================
+ Hits 7283 7285 +2
+ Misses 3456 3454 -2
Partials 532 532 ☔ View full report in Codecov by Sentry. |
savitaashture
force-pushed
the
srvkp-5571
branch
from
July 24, 2024 07:58
aeb6bdb
to
00a55a5
Compare
enarha
reviewed
Jul 24, 2024
/lgtm |
savitaashture
force-pushed
the
srvkp-5571
branch
from
July 25, 2024 11:26
00a55a5
to
1132d40
Compare
savitaashture
changed the title
[WIP] fix: controller crash when provenance is set only on the global repo
fix: controller crash when provenance is set only on the global repo
Jul 25, 2024
savitaashture
force-pushed
the
srvkp-5571
branch
from
July 25, 2024 12:01
1132d40
to
0428e3b
Compare
I have corrected e2e But why linter is failing i need to check |
savitaashture
force-pushed
the
srvkp-5571
branch
from
July 25, 2024 15:03
0428e3b
to
1e9f8ea
Compare
/test linters |
savitaashture
force-pushed
the
srvkp-5571
branch
from
July 26, 2024 16:41
89ad4c9
to
aab624b
Compare
This commit fixes the controller crash by adding a nil pointer check before accessing the elements of an object. Issue: https://issues.redhat.com/browse/SRVKP-5571 Signed-off-by: Savita Ashture <[email protected]>
This will fix vale config file to compatible with latest version as it was throwing error that IgnoredScopes and SkippedScopes to be defined before syntx options
savitaashture
force-pushed
the
srvkp-5571
branch
from
July 26, 2024 16:43
aab624b
to
ca4fc85
Compare
I like it better with the updated test. Thanks. |
/test go-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the controller crash by adding
a nil pointer check before accessing the elements of an object. Issue: https://issues.redhat.com/browse/SRVKP-5571
Verification:
Created Global Repo like below
created local Repo like below
Signed-off-by: Savita Ashture [email protected]
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).