Skip to content

Commit

Permalink
Remove deprecated deadline option from go-lint
Browse files Browse the repository at this point in the history
Was removed in 0.57.0

Fixes #1628

Signed-off-by: Chmouel Boudjnah <[email protected]>
  • Loading branch information
chmouel authored and savitaashture committed Mar 20, 2024
1 parent 803b25f commit 6b314ca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
issues:
exclude-dirs:
- vendor
- pkg/provider/gitea/structs
exclude-rules:
# Exclude some linters from running on tests files.
- path: _test\.go
Expand All @@ -7,9 +10,6 @@ issues:
run:
build-tags:
- e2e
skip-dirs:
- vendor
- pkg/provider/gitea/structs
linters-settings:
gocritic:
disabled-checks:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ lint-go: ## runs go linter on all go files
@$(GOLANGCI_LINT) run ./... --modules-download-mode=vendor \
--max-issues-per-linter=0 \
--max-same-issues=0 \
--deadline $(TIMEOUT_UNIT)
--timeout $(TIMEOUT_UNIT)

.PHONY: lint-yaml
lint-yaml: ${YAML_FILES} ## runs yamllint on all yaml files
Expand Down Expand Up @@ -143,7 +143,7 @@ fix-golangci-lint: ## run golangci-lint and fix on all go files
@$(GOLANGCI_LINT) run ./... --modules-download-mode=vendor \
--max-issues-per-linter=0 \
--max-same-issues=0 \
--deadline $(TIMEOUT_UNIT) \
--timeout $(TIMEOUT_UNIT) \
--fix
@[[ -n `git status --porcelain` ]] && { echo "Go files has been cleaned 🧹. Cleaned Files: ";git status --porcelain ;} || echo "Go files are clean ✨"

Expand Down

0 comments on commit 6b314ca

Please sign in to comment.