Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: synchronise to ocm-api-model 0.0.365 #935

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Lir10
Copy link

@Lir10 Lir10 commented Mar 17, 2024

No description provided.

@@ -27,7 +27,7 @@ export PATH := $(LOCAL_BIN_PATH):$(PATH)
export CGO_ENABLED=0

# Details of the model to use:
model_version:=v0.0.364
model_version:=v0.0.365
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually put this as bump MRs, and document in the CHANGES.md accordingly. See 0.1.410 as example

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lir10 are you planing to update the CHANGES.md in a followup MR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep here it is #936

@Lir10 Lir10 force-pushed the bump_release_365 branch 2 times, most recently from fcb6d53 to ace0977 Compare March 18, 2024 08:37
@Lir10 Lir10 force-pushed the bump_release_365 branch from ace0977 to a00e351 Compare March 18, 2024 09:07
@@ -27,7 +27,7 @@ export PATH := $(LOCAL_BIN_PATH):$(PATH)
export CGO_ENABLED=0

# Details of the model to use:
model_version:=v0.0.364
model_version:=v0.0.365
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lir10 are you planing to update the CHANGES.md in a followup MR?

Copy link
Contributor

@tzvatot tzvatot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzvatot tzvatot merged commit 81c7ce7 into openshift-online:main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants