Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a Why section to the readme #91

Merged
merged 2 commits into from
May 28, 2024

Conversation

mikeshng
Copy link
Contributor

@mikeshng mikeshng commented May 17, 2024

I am trying to show maestro as a possible solution for another project but the README is missing some motivations on why this project is needed. This PR is to address that missing overview.

@mikeshng
Copy link
Contributor Author

/assign @clyang82

/assign @qiujian16

/assign @jnpacker

PTAL. I might be saying wrong things here so please feel free to criticize. Thanks!

![Maestro Architecture](./arch.png)

## Why

Maestro was created to address several critical challenges associated with managing Kubernetes clusters at scale.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is good in that we should see performance and scalability improvements by using Maestro, as you note.

Another motivation (I think, perhaps, primary motivation) was to improve the security architecture.

By using Maestro, we do not need kubeconfigs. Our Cluster Service (CS) deployment would no longer need kubeconfigs or direct access to customer clusters. CS just uses the Maestro API.

Only the Maestro consumer in a management cluster needs kubeconfigs, thus improving security.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark for the review!

Could you please help me word it in a way that's more generic and not mention CS, SD, MC, HCP etc?
I am trying to show maestro as a possible solution for another project and it's not related to SD. Maybe closer to self managed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a generic sentence about not needing kubeconfig. Maybe it's a bit vague but PTAL. Thanks.

@clyang82
Copy link
Contributor

@mikeshng Thanks for your PR. Maybe add a description for the purpose of this PR. something like show maestro as a possible solution for another project.

@qiujian16
Copy link
Contributor

lgtm

@clyang82
Copy link
Contributor

/lgtm

leave it to @markturansky for another look.

@clyang82 clyang82 merged commit 176e53e into openshift-online:main May 28, 2024
1 of 2 checks passed
@mikeshng mikeshng deleted the add-why-readme branch May 28, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants