Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The template to run maestro in ROSA #209

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

skeeey
Copy link
Contributor

@skeeey skeeey commented Oct 30, 2024

No description provided.

@skeeey
Copy link
Contributor Author

skeeey commented Oct 30, 2024

/assign @clyang82

1 similar comment
@skeeey
Copy link
Contributor Author

skeeey commented Oct 31, 2024

/assign @clyang82

selector:
matchLabels:
app: maestro
replicas: ${{SERVER_REPLICAS}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no error for 2 braces?

Copy link
Contributor Author

@skeeey skeeey Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no errors, it works, and I changed it to 1 brace to keep same code style with others

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clyang82 clyang82 merged commit dae3b67 into openshift-online:main Nov 1, 2024
3 of 4 checks passed
@skeeey skeeey deleted the rosa branch November 1, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants