Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Refactor install-config #93

Merged
merged 1 commit into from
May 31, 2019
Merged

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented May 30, 2019

Based on 4.2 PR, which needs to get in first. Goes along with openshift-metal3/dev-scripts#578

Fixes #57

Some to-dos:

  • Deal with image URL's, can we take them out of the install-config and use known adresses?
  • Support creating the worker Ironic node objects (e.g. all the hosts we know about)
  • Use the default profile in BMO when hardwareProfile is empty

Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This will make it much easier to add host registration, too.

@stbenjam stbenjam force-pushed the install-config branch 4 times, most recently from 813027e to 48d1750 Compare May 31, 2019 14:00
@stbenjam stbenjam changed the title [WIP] Refactor install-config Refactor install-config May 31, 2019
@stbenjam
Copy link
Member Author

Thanks, going to merge this so it's part of the 4.2 rebase. As discussed yesterday we can iterate on the issues identified above.

@stbenjam stbenjam merged commit 06d0c66 into openshift-metal3:master May 31, 2019
@stbenjam stbenjam deleted the install-config branch May 31, 2019 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review of install-config structure
2 participants