-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rhcos to 42.80.20190827.1 #766
Conversation
I've been testing this locally, and the bootstrap VM doesn't come up correctly - still trying to figure out why, but it's also been replicated by @karmab and a few other folks - reverting openshift/installer to 0454021 appears to resolve the issue so I suspect some badness in the new qemu image |
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1099/ |
On the latest rhcos the code that keeps retrying waiting for etcd cluster to come up isn't working...
This should retry: but it doesn't. |
I can verify it's exiting 0, so we never retry:
Here's the full debug logs: https://gist.github.com/stbenjam/24bf10326664ddee968df407c716e20b podman version:
I don't notice any changes to etcd, it's last commit is from July. |
Interactively in the container, it does return 1:
|
Summary:
|
42.80.20190827.1 is out with the fixes, got a good local install. openshift/installer#2277 bumps the installer rhcos. |
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1103/ |
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1104/ |
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1105/ |
Ok with openshift/installer#2277 and rebased to include #775 this is working for me locally 👍 @stbenjam thanks for all the effort yesterday debugging the podman issues! :) |
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1107/ |
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1108/ |
Proven locally and CI so should be good to go when the installer PR lands and we remove the temporary stuff here to test it 👍 |
Great thanks! openshift PR landed. We should get a nightly with that fix in about an hour. |
Looks like the nightly picked up the new image so I removed the changes to run the installer from source and force-pushed - I then saw #778 which looks good too, we can discuss later which approach you'd prefer to go with. |
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1111/ |
Since CI passed here, let’s merge this. #778 can go in on top of this later |
We'll need this when openshift/installer#2264 lands.
Eventually we can avoid this if and when openshift/installer#2092 lands, otherwise there's not a convenient way to get the data out of the installer.