Allow use of locally built images for CI/testing #759

derekhiggins · 2019-08-21T14:27:05Z

Add the ability for the bootstrap node to pull localy
built images for development and ci jobs.

04_setup_ironic.sh

common.sh

metal3ci · 2019-08-21T18:23:04Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1079/

metal3ci · 2019-08-21T19:57:52Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1080/

metal3ci · 2019-08-30T18:38:17Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1118/

metal3ci · 2019-09-03T11:24:43Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1120/

04_setup_ironic.sh

hardys · 2019-09-05T09:22:31Z

04_setup_ironic.sh

+        export $IMAGE_VAR=192.168.111.1:5000/localimages/${!IMAGE_VAR}
+
+        clone_installer
+        cd /home/notstack/go/src/github.com/openshift/installer


This should use $OPENSHIFT_INSTALL_PATH

04_setup_ironic.sh

hardys · 2019-09-05T09:26:59Z

I think this needs an update since #778 landed, perhaps we can move the image build into the 03 script and rename it?

Also it'd be nice if we could figure out some way to not hijack git tracked files in-place, don't have a good suggestion of how we do that yet though.

russellb · 2019-09-05T17:17:14Z

This could be dropped in favor of looking ahead to OpenShift CI, where it would be building custom ironic images if necessary and including them in the release image for that CI job. Now that openshift/installer#2234 has landed, we really shouldn't be using metal3-io ironic images anywhere in OpenShift.

derekhiggins · 2019-09-06T13:07:19Z

This could be dropped in favor of looking ahead to OpenShift CI, where it would be building custom ironic images if necessary and including them in the release image for that CI job. Now that openshift/installer#2234 has landed, we really shouldn't be using metal3-io ironic images anywhere in OpenShift.

I've been wondering about this recently, should we just drop the metal3 ironic images and work directly on the openshift ones?

metal3ci · 2019-09-13T10:45:45Z

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1141/

metal3ci · 2019-09-13T14:29:17Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1144/

juliakreger · 2019-09-19T15:43:02Z

@russellb So it seems we're blocked on making changes to metal3-io repos without something like this, and we're blocked on output images from openshift on code data, so it seems if we don't have a happy place to even test changes :\ I feel like Derek is raising a good point, seems like we at least need to drop something somewhere to unblock things.

russellb · 2019-09-19T20:19:07Z

The metal3-io images are not used anywhere in OpenShift directly. They are used directly by metal3-dev-env, though. We still need them for the usage of metal3-io outside of OpenShift.

derekhiggins · 2019-09-20T09:59:14Z

The metal3-io images are not used anywhere in OpenShift directly. They are used directly by metal3-dev-env, though. We still need them for the usage of metal3-io outside of OpenShift.

ok, so I guess the answer is the I/we need to switch to using metal3-dev-env when doing development on the ironic-images

derekhiggins · 2019-09-27T16:59:48Z

Now uses a local release image, and should make it possible to use custom versions of any of the images mentioned in the release image (not just the ironic images)

metal3ci · 2019-09-27T18:18:49Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1183/

metal3ci · 2019-09-30T23:28:17Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1185/

metal3ci · 2019-10-01T09:53:42Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1186/

hardys · 2019-10-01T16:59:03Z

This is working great for me, the only thing missing I think is to open tcp/5000 in the firewall as I had to do that manually.

0325b5394bcb0       192.168.111.1:5000/localimages/machine-config-operator@sha256:bfe713e2dd66c3e7803f1aee82cbadec3d303d2a75a968efdcb913fc37b883e2   4 minutes ago       Running             machine-config-server       0                   9294cfa7ce668
9c72ef5510021       192.168.111.1:5000/localimages/machine-config-operator@sha256:bfe713e2dd66c3e7803f1aee82cbadec3d303d2a75a968efdcb913fc37b883e2   4 minutes ago       Exited              machine-config-controller   0                   9294cfa7ce668

That was with export MACHINE_CONFIG_OPERATOR_LOCAL_IMAGE=https://github.com/openshift/machine-config-operator

metal3ci · 2019-10-02T10:09:44Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1189/

metal3ci · 2019-10-02T11:22:33Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1190/

hardys · 2019-10-02T14:57:32Z

common.sh

@@ -39,6 +39,11 @@ source $CONFIG
 export OPENSHIFT_RELEASE_IMAGE="${OPENSHIFT_RELEASE_IMAGE:-registry.svc.ci.openshift.org/ocp/release:4.2}"
 export OPENSHIFT_INSTALL_PATH="$GOPATH/src/github.com/openshift/installer"

+if env | grep -q "_LOCAL_IMAGE=" ; then
+    # We need a custome installer (allows http image pulls for local images)


Any more info on this - is it a configuration that's turned off in the release-payload installer build?

Its needed because in 04_setup_ironic.sh we are adding a file into the filesystem

echo -e "[registries.insecure]\nregistries = ['192.168.111.1:5000']" > $OPENSHIFT_INSTALL_PATH/data/data/bootstrap/baremetal/files/etc/containers/registries.conf

we need to build a custom installer including this file

Ah I see, thanks - I saw the 99_local-registry.yaml.optional and assumed we could do all the local-registry config via an asset, but I guess we need registries.conf before the MCO runs.

Modifying the installer checkout seems fine, but one alternative would be to generate the ignition-configs via the installer, then inject the registries.conf via ignition - we did that early in dev-scripts IIRC for some other things.

Modifying the installer checkout seems fine, but one alternative would be to generate the ignition-configs via the installer, then inject the registries.conf via ignition - we did that early in dev-scripts IIRC for some other things.

I'll look into doing this as an alternative

I'll look into doing this as an alternative

Not necessarily saying that we should, just wanted to mention it as a possible alternative 👍

hardys

This is working well for me, I think it's ready to merge if you're happy @derekhiggins ?

hardys · 2019-10-02T15:46:27Z

I guess some update to the README would be nice, to document the new/easier test workflow?

derekhiggins · 2019-10-02T16:03:33Z

This is working well for me, I think it's ready to merge if you're happy @derekhiggins ?

I'll update the README then I'm happy to merge if you are

Add the ability to use a local release image containing entries referencing custom container images. The local references can be container images or git repositories which will be built to container images.

metal3ci · 2019-10-02T17:53:26Z

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1191/

derekhiggins added the CI check this PR with CI label Aug 21, 2019

stbenjam reviewed Aug 21, 2019

View reviewed changes

04_setup_ironic.sh Outdated Show resolved Hide resolved

stbenjam reviewed Aug 21, 2019

View reviewed changes

common.sh Outdated Show resolved Hide resolved

derekhiggins force-pushed the local-bootstrap-images branch 2 times, most recently from 3594ee7 to cb76de9 Compare August 21, 2019 16:58

derekhiggins force-pushed the local-bootstrap-images branch from cb76de9 to 06c332d Compare August 30, 2019 14:29

derekhiggins mentioned this pull request Sep 4, 2019

Move to Train branch metal3-io/ironic-image#93

Merged

hardys reviewed Sep 5, 2019

View reviewed changes

04_setup_ironic.sh Outdated Show resolved Hide resolved

hardys reviewed Sep 5, 2019

View reviewed changes

04_setup_ironic.sh Outdated Show resolved Hide resolved

hardys mentioned this pull request Sep 9, 2019

WIP CI for networking components #801

Closed

derekhiggins force-pushed the local-bootstrap-images branch from 06c332d to dfb3b35 Compare September 13, 2019 10:35

derekhiggins force-pushed the local-bootstrap-images branch from dfb3b35 to f7acf18 Compare September 13, 2019 13:09

derekhiggins force-pushed the local-bootstrap-images branch from f7acf18 to 43bab70 Compare September 27, 2019 16:56

derekhiggins force-pushed the local-bootstrap-images branch from 43bab70 to 1814b8f Compare September 30, 2019 22:18

derekhiggins force-pushed the local-bootstrap-images branch from 1814b8f to fde5aed Compare October 1, 2019 08:38

derekhiggins force-pushed the local-bootstrap-images branch 2 times, most recently from 09a75b4 to bf5f6be Compare October 2, 2019 09:24

hardys reviewed Oct 2, 2019

View reviewed changes

hardys approved these changes Oct 2, 2019

View reviewed changes

derekhiggins force-pushed the local-bootstrap-images branch from bf5f6be to 22f8200 Compare October 2, 2019 16:20

Pull localy built images from local

cda0d11

Add the ability to use a local release image containing entries referencing custom container images. The local references can be container images or git repositories which will be built to container images.

derekhiggins force-pushed the local-bootstrap-images branch from 22f8200 to cda0d11 Compare October 2, 2019 16:21

hardys merged commit 14bef02 into openshift-metal3:master Oct 3, 2019

hardys changed the title ~~Pull locally built ironic images for use on bootstrap node~~ Allow use of locally built images for CI/testing Oct 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow use of locally built images for CI/testing #759

Allow use of locally built images for CI/testing #759

derekhiggins commented Aug 21, 2019

metal3ci commented Aug 21, 2019

metal3ci commented Aug 21, 2019

metal3ci commented Aug 30, 2019

metal3ci commented Sep 3, 2019

hardys Sep 5, 2019

hardys commented Sep 5, 2019

russellb commented Sep 5, 2019

derekhiggins commented Sep 6, 2019

metal3ci commented Sep 13, 2019

metal3ci commented Sep 13, 2019

juliakreger commented Sep 19, 2019

russellb commented Sep 19, 2019

derekhiggins commented Sep 20, 2019

derekhiggins commented Sep 27, 2019

metal3ci commented Sep 27, 2019

metal3ci commented Sep 30, 2019

metal3ci commented Oct 1, 2019

hardys commented Oct 1, 2019 •

edited

Loading

metal3ci commented Oct 2, 2019

metal3ci commented Oct 2, 2019

hardys Oct 2, 2019

derekhiggins Oct 2, 2019

hardys Oct 2, 2019

derekhiggins Oct 2, 2019

hardys Oct 2, 2019

hardys left a comment

hardys commented Oct 2, 2019

derekhiggins commented Oct 2, 2019

metal3ci commented Oct 2, 2019

Allow use of locally built images for CI/testing #759

Allow use of locally built images for CI/testing #759

Conversation

derekhiggins commented Aug 21, 2019

metal3ci commented Aug 21, 2019

metal3ci commented Aug 21, 2019

metal3ci commented Aug 30, 2019

metal3ci commented Sep 3, 2019

hardys Sep 5, 2019

Choose a reason for hiding this comment

hardys commented Sep 5, 2019

russellb commented Sep 5, 2019

derekhiggins commented Sep 6, 2019

metal3ci commented Sep 13, 2019

metal3ci commented Sep 13, 2019

juliakreger commented Sep 19, 2019

russellb commented Sep 19, 2019

derekhiggins commented Sep 20, 2019

derekhiggins commented Sep 27, 2019

metal3ci commented Sep 27, 2019

metal3ci commented Sep 30, 2019

metal3ci commented Oct 1, 2019

hardys commented Oct 1, 2019 • edited Loading

metal3ci commented Oct 2, 2019

metal3ci commented Oct 2, 2019

hardys Oct 2, 2019

Choose a reason for hiding this comment

derekhiggins Oct 2, 2019

Choose a reason for hiding this comment

hardys Oct 2, 2019

Choose a reason for hiding this comment

derekhiggins Oct 2, 2019

Choose a reason for hiding this comment

hardys Oct 2, 2019

Choose a reason for hiding this comment

hardys left a comment

Choose a reason for hiding this comment

hardys commented Oct 2, 2019

derekhiggins commented Oct 2, 2019

metal3ci commented Oct 2, 2019

hardys commented Oct 1, 2019 •

edited

Loading