Replace multi-service ironic container with several containers #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfournie
reviewed
Jun 30, 2019
| @@ -60,7 +60,7 @@ wait_for_json ironic \ | |||
| 20 \ | |||
| -H "Accept: application/json" -H "Content-Type: application/json" -H "User-Agent: wait-for-json" -H "X-Auth-Token: $OS_TOKEN" | |||
|
|
|||
| if [ $(sudo podman ps | grep -w -e "ironic$" -e "ironic-inspector$" -e "dnsmasq" -e "httpd" | wc -l) != 4 ]; then | |||
| if [ $(sudo podman ps | grep -w -e "ironic-api$" -e "ironic-conductor$" -e "ironic-inspector$" -e "dnsmasq" -e "httpd" | wc -l) != 5 ]; then | |||
There was a problem hiding this comment.
Should this check ironic-exporter too?
There was a problem hiding this comment.
It's not strictly required for deployment, so I'd avoid it here.
|
Note that pretty soon we'll move away from dev-scripts managing all the ironic things, so we'll need to align metal3-io/baremetal-operator#212 #635 and openshift-metal3/kni-installer#100 with this. |
|
Right. This patch is still useful to prove that the split works (I'll run the CI when the dependency merges). |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/842/ |
derekhiggins
approved these changes
Jul 8, 2019
|
Ok this passed CI and we'll need this landed to test a follow-up PR to ironic-image that adds logging for the new entrypoints, so lets go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires metal3-io/ironic-image#62