Move from go 1.17 to go1.18 #295

swatisehgal · 2022-05-19T10:11:04Z

Ran go mod tidy
Dockerfile updates
Github CI workflows to go 1.18.1 update

openshift-ci · 2022-05-19T10:11:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [swatisehgal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

swatisehgal · 2022-05-19T11:01:22Z

CI fails when it runs make verify-generate, which seems to be running fine in my local environment 🤔:

$ make verify-generated
Using operator-sdk cached at bin/operator-sdk_linux_amd64
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
""bin"/"operator-sdk_linux_amd64"" generate kustomize manifests -q
cd config/manager && /home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/kustomize edit set image controller=quay.io/openshift-kni/numaresources-operator:4.11.999-snapshot
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/kustomize build config/manifests | ""bin"/"operator-sdk_linux_amd64"" generate bundle -q --overwrite --version 4.11.999-snapshot --channels=alpha --default-channel=alpha
INFO[0000] Creating bundle.Dockerfile                   
INFO[0000] Creating bundle/metadata/annotations.yaml    
INFO[0000] Bundle metadata generated suceessfully       
""bin"/"operator-sdk_linux_amd64"" bundle validate ./bundle
INFO[0000] All validation tests have completed successfully 
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
Verifying that all code is committed after updating deps and formatting and generating code
hack/verify-generated.sh

swatisehgal · 2022-05-19T11:01:35Z

/retest

ffromani · 2022-05-19T11:06:36Z

/cc

ffromani · 2022-05-19T11:26:37Z

go.mod

@@ -1,6 +1,6 @@
 module github.com/openshift-kni/numaresources-operator

-go 1.17
+go 1.18


you may want to pull RTE 0.6.0

Ah, thanks for cutting a release on the RTE side!

Will update this PR now.

Move from go 1.17 to go1.18 Ran `go mod tidy` Signed-off-by: Swati Sehgal <[email protected]>

Signed-off-by: Swati Sehgal <[email protected]>

ffromani · 2022-05-19T11:54:00Z

CI fails when it runs make verify-generate, which seems to be running fine in my local environment thinking:

$ make verify-generated
Using operator-sdk cached at bin/operator-sdk_linux_amd64
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
""bin"/"operator-sdk_linux_amd64"" generate kustomize manifests -q
cd config/manager && /home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/kustomize edit set image controller=quay.io/openshift-kni/numaresources-operator:4.11.999-snapshot
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/kustomize build config/manifests | ""bin"/"operator-sdk_linux_amd64"" generate bundle -q --overwrite --version 4.11.999-snapshot --channels=alpha --default-channel=alpha
INFO[0000] Creating bundle.Dockerfile                   
INFO[0000] Creating bundle/metadata/annotations.yaml    
INFO[0000] Bundle metadata generated suceessfully       
""bin"/"operator-sdk_linux_amd64"" bundle validate ./bundle
INFO[0000] All validation tests have completed successfully 
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
Verifying that all code is committed after updating deps and formatting and generating code
hack/verify-generated.sh

make sure to clean up your local bin/ to see if it reproduces locally

Signed-off-by: Swati Sehgal <[email protected]>

swatisehgal · 2022-05-19T12:31:02Z

make sure to clean up your local bin/ to see if it reproduces locally

Thanks for that, yeah the issue is reproducing locally.

swatisehgal · 2022-05-19T12:42:26Z

Looks like this is a known issue :kubernetes-sigs/kubebuilder#2530. The reason of the failure is because kubebuilder does not support go 1.18 yet: kubernetes-sigs/kubebuilder#2561.

ffromani · 2022-05-19T12:49:08Z

Looks like this is a known issue :kubernetes-sigs/kubebuilder#2530. The reason of the failure is because kubebuilder does not support go 1.18 yet: kubernetes-sigs/kubebuilder#2561.

to move forward, I'd be in favour of applying a local fix like

$ git diff
diff --git a/Makefile b/Makefile
index 7c44e5b7..e9c85402 100644
--- a/Makefile
+++ b/Makefile
@@ -236,26 +236,26 @@ undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/confi
 
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-       $(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/[email protected])
+       $(call go-install-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/[email protected])
 
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 kustomize: ## Download kustomize locally if necessary.
-       $(call go-get-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/[email protected])
+       $(call go-install-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/[email protected])
 
 ENVTEST = $(shell pwd)/bin/setup-envtest
 envtest: ## Download envtest-setup locally if necessary.
-       $(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
+       $(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)
 
-# go-get-tool will 'go get' any package $2 and install it to $1.
+# go-install-tool will 'go get' any package $2 and install it to $1.
 PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
-define go-get-tool
+define go-install-tool
 @[ -f $(1) ] || { \
 set -e ;\
 TMP_DIR=$$(mktemp -d) ;\
 cd $$TMP_DIR ;\
 go mod init tmp ;\
 echo "Downloading $(2)" ;\
-GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\
+GOBIN=$(PROJECT_DIR)/bin go install $(2) ;\
 rm -rf $$TMP_DIR ;\
 }
 endef

I think this is actually something we can carry for the time being.
xref: https://go.dev/doc/go-get-install-deprecation

As of today, Kube-builder does not support go 1.18: kubernetes-sigs/kubebuilder#2561. Also, note that installing executables with go get is deprecated in go1.18 (xref:https://go.dev/doc/go-get-install-deprecation). Co-authored-by: Francesco Romani <[email protected]> Signed-off-by: Swati Sehgal <[email protected]>

ffromani · 2022-05-19T14:36:56Z

I'm in favour of moving to the latest kustomize v4. I'm not aware of any regression this would cause, and a quick glance at the changes between v3.8 and v4.5 revealed blockers.
xref: kubernetes-sigs/kustomize#3618

swatisehgal · 2022-05-19T15:05:59Z

I'm in favour of moving to the latest kustomize v4. I'm not aware of any regression this would cause, and a quick glance at the changes between v3.8 and v4.5 revealed blockers. xref: kubernetes-sigs/kustomize#3618

Good catch actually, I over-enthisiastically pushed the changes without testing locally, staying with Kustomize version 3.8.7 is giving me the error as linked in the issue and the one we are getting in the CI as well:


$ make verify-generated
Using operator-sdk cached at bin/operator-sdk_linux_amd64
/home/swsehgal/go/src/github.com/openshift-kni/numaresources-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
go: creating new go.mod: module tmp
Downloading sigs.k8s.io/kustomize/kustomize/[email protected]
go: sigs.k8s.io/kustomize/kustomize/[email protected] (in sigs.k8s.io/kustomize/kustomize/[email protected]):
        The go.mod file for the module providing named packages contains one or
        more exclude directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.
make: *** [Makefile:243: kustomize] Error 1

I think the issue you linked has been resolved after removing excluded dependencies from kustomize go mod:
kubernetes-sigs/kustomize#4387 so after bumping kustomize to 4.5 we overcome the current issue.

swatisehgal · 2022-05-19T15:06:22Z

Posting the fix shortly.

Signed-off-by: Swati Sehgal <[email protected]>

ffromani · 2022-05-19T15:26:36Z

/lgtm

openshift-ci bot requested review from marioferh and MarSik May 19, 2022 10:11

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022

openshift-ci bot requested a review from ffromani May 19, 2022 11:06

ffromani reviewed May 19, 2022

View reviewed changes

swatisehgal added 3 commits May 19, 2022 12:47

go1.18: Update go.mod

9c1ce78

Move from go 1.17 to go1.18 Ran `go mod tidy` Signed-off-by: Swati Sehgal <[email protected]>

go1.18: Update Dockerfiles

6670740

Signed-off-by: Swati Sehgal <[email protected]>

go1.18: Update github CI workflows to go 1.18.1

fc15218

Signed-off-by: Swati Sehgal <[email protected]>

swatisehgal force-pushed the go1.18 branch from 25da959 to fc15218 Compare May 19, 2022 11:47

go1.18: Vendor updates

5cca0e0

Signed-off-by: Swati Sehgal <[email protected]>

go1.18: Update kustomize to latest version (v4.5.4)

70b85f7

Signed-off-by: Swati Sehgal <[email protected]>

openshift-ci bot assigned ffromani May 19, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022

openshift-merge-robot merged commit e0e3fc7 into openshift-kni:main May 19, 2022

ffromani mentioned this pull request May 19, 2022

[KNI] go1.18: Update go.mod openshift-kni/scheduler-plugins#36

Merged

swatisehgal deleted the go1.18 branch May 19, 2022 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move from go 1.17 to go1.18 #295

Move from go 1.17 to go1.18 #295

swatisehgal commented May 19, 2022

openshift-ci bot commented May 19, 2022

swatisehgal commented May 19, 2022

swatisehgal commented May 19, 2022

ffromani commented May 19, 2022

ffromani May 19, 2022

swatisehgal May 19, 2022

swatisehgal May 19, 2022

ffromani commented May 19, 2022

swatisehgal commented May 19, 2022

swatisehgal commented May 19, 2022

ffromani commented May 19, 2022

ffromani commented May 19, 2022

swatisehgal commented May 19, 2022

swatisehgal commented May 19, 2022

ffromani commented May 19, 2022

Move from go 1.17 to go1.18 #295

Move from go 1.17 to go1.18 #295

Conversation

swatisehgal commented May 19, 2022

openshift-ci bot commented May 19, 2022

swatisehgal commented May 19, 2022

swatisehgal commented May 19, 2022

ffromani commented May 19, 2022

ffromani May 19, 2022

Choose a reason for hiding this comment

swatisehgal May 19, 2022

Choose a reason for hiding this comment

swatisehgal May 19, 2022

Choose a reason for hiding this comment

ffromani commented May 19, 2022

swatisehgal commented May 19, 2022

swatisehgal commented May 19, 2022

ffromani commented May 19, 2022

ffromani commented May 19, 2022

swatisehgal commented May 19, 2022

swatisehgal commented May 19, 2022

ffromani commented May 19, 2022