Bug 2073439: ztp: Disable podman logging when extracting container data

[lack]

As described in containers/podman#13779,
podman by default logs all of a container's stdout in order to retain
info to make 'podman logs' work. But this extra copy of stdout can be
overrun and cause hangs when shipping large amounts of data through
stdout (as in the case when piping out a tar stream). Changing the
instructions and documentation to add '--log-driver=none' to the podman
commandline disables this extra unneeded logging and prevents hangs.

Signed-off-by: Jim Ramsay [email protected]

/cc @imiller0 @serngawy

[openshift-ci]

@lack: This pull request references Bugzilla bug 2073439, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2073439: ztp: Disable podman logging when extracting container data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lack]

/bugzilla refresh

[openshift-ci]

@lack: This pull request references Bugzilla bug 2073439, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lack]

Tested by running this in a loop to make sure of no hangs, even when extracting the larger /kustomize directory structure:

i=0; while [[ $((++i)) -lt 1000 ]]; do echo "Starting $i"; podman run --rm --log-driver=none ztp-site-generator:latest extract /kustomize --tar | tar t > k-$i.output; echo "Done $i"; done

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ztp/OWNERS [lack,serngawy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@lack: All pull requests linked via external trackers have merged:

• openshift-kni/cnf-features-deploy#1065

Bugzilla bug 2073439 has been moved to the MODIFIED state.

In response to this:

Bug 2073439: ztp: Disable podman logging when extracting container data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lack]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@lack: #1065 failed to apply on top of branch "release-4.10":

Applying: ztp: Disable podman logging when extracting container data
Using index info to reconstruct a base tree...
M	ztp/gitops-subscriptions/argocd/README.md
M	ztp/resource-generator/Makefile
M	ztp/resource-generator/entrypoints/extract
Falling back to patching base and 3-way merge...
Auto-merging ztp/resource-generator/entrypoints/extract
CONFLICT (content): Merge conflict in ztp/resource-generator/entrypoints/extract
Auto-merging ztp/resource-generator/Makefile
CONFLICT (content): Merge conflict in ztp/resource-generator/Makefile
Auto-merging ztp/gitops-subscriptions/argocd/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: Disable podman logging when extracting container data
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.