Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Backport of knative-extensions/kn-plugin-event#375 #556

Conversation

cardil
Copy link
Member

@cardil cardil commented Nov 5, 2024

release-1.16

Backport of knative-extensions#375

Requires openshift-knative/client#504

@openshift-ci openshift-ci bot requested review from dsimansk and lkingland November 5, 2024 12:35
@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
go.mod Outdated Show resolved Hide resolved
@cardil
Copy link
Member Author

cardil commented Nov 5, 2024

This is failing each time, seen also on other PRs vs release-1.16 (#545):

=== RUN   TestInClusterSender/KnativeService/Setup/Deploy_KnService
=== PAUSE TestInClusterSender/KnativeService/Setup/Deploy_KnService
=== CONT  TestInClusterSender/KnativeService/Setup/Deploy_KnService
    kn_service.go:144: admission webhook "validation.webhook.serving.knative.dev" denied the request: validation failed: invalid value: .config/wathola: spec.template.spec.containers[0].volumeMounts[0].mountPath
--- FAIL: TestInClusterSender/KnativeService/Setup/Deploy_KnService (0.02s)

This happens only on Openshift, upstream is good. I need to debug root cause.

@cardil
Copy link
Member Author

cardil commented Nov 5, 2024

#557 should fix the test failure in this PR

openshift-merge-bot bot pushed a commit to openshift-knative/client that referenced this pull request Dec 6, 2024
@cardil cardil force-pushed the backport/1.16/pr-375 branch from 6dac5ed to ce7bb5f Compare December 6, 2024 18:39
@dsimansk
Copy link

dsimansk commented Dec 6, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ed2c049 into openshift-knative:release-1.16 Dec 6, 2024
6 checks passed
@cardil cardil deleted the backport/1.16/pr-375 branch December 9, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants