-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images/cluster-version-operator: auto_label for merge #1778
images/cluster-version-operator: auto_label for merge #1778
Conversation
Currently 4.12 is the dev release, so it only needs lgtm and approved [1]. But eventually 4.12 will hit code-freeze, and then it will also need bugzilla/valid-bug and staff-eng-approved [2]. And eventually it will be a generally available release, and then it will need approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, and lgtm [3]. The CVO is very flexible about Go versions and whatnot, so we don't need any of these sign-offs for CI-alignment pull requests. With this commit, we add all the labels we'll need to merge at any stage of the 4.12 lifecycle. And hopefully the same configuration will propagate into 4.13 once we get release branches here for that. [1]: https://github.com/openshift/release/blob/7114512b31971dcfe83454a40ed77f8881cecc73/core-services/prow/02_config/openshift/cluster-version-operator/_prowconfig.yaml#L57-L62 [2]: https://github.com/openshift/release/blob/7114512b31971dcfe83454a40ed77f8881cecc73/core-services/prow/02_config/openshift/cluster-version-operator/_prowconfig.yaml#L40-L47 [3]: https://github.com/openshift/release/blob/7114512b31971dcfe83454a40ed77f8881cecc73/core-services/prow/02_config/openshift/cluster-version-operator/_prowconfig.yaml#L3-L30
@wking: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Build #1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Currently 4.12 is the dev release, so it only needs
lgtm
andapproved
. But eventually 4.12 will hit code-freeze, and then it will also needbugzilla/valid-bug
andstaff-eng-approved
. And eventually it will be a generally available release, and then it will needapproved
,backport-risk-assessed
,bugzilla/valid-bug
,cherry-pick-approved
, andlgtm
. The CVO is very flexible about Go versions and whatnot, so we don't need any of these sign-offs for CI-alignment pull requests. With this commit, we add all the labels we'll need to merge at any stage of the 4.12 lifecycle. And hopefully the same configuration will propagate into 4.13 once we get release branches here for that.