Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

use friendlier defaults for egress and permissive mode #4837

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

steeling
Copy link
Contributor

Set enableEgress and permissive mode to default to true in values.yaml

@steeling steeling force-pushed the feature/permissive branch 4 times, most recently from 1c2b772 to eac1c40 Compare June 22, 2022 01:16
@steeling steeling marked this pull request as ready for review June 22, 2022 11:40
.env.example Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #4837 (c247091) into main (8da8732) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4837      +/-   ##
==========================================
- Coverage   69.47%   69.37%   -0.11%     
==========================================
  Files         218      218              
  Lines       15766    15819      +53     
==========================================
+ Hits        10954    10975      +21     
- Misses       4760     4792      +32     
  Partials       52       52              
Flag Coverage Δ
unittests 69.37% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/certificate/options.go 33.33% <0.00%> (-31.38%) ⬇️
pkg/configurator/methods.go 65.38% <0.00%> (-6.65%) ⬇️
pkg/certificate/fake_manager.go 69.11% <0.00%> (-2.10%) ⬇️
pkg/certificate/certificate.go 94.87% <0.00%> (-0.97%) ⬇️
pkg/ingress/gateway.go 78.57% <0.00%> (-0.17%) ⬇️
pkg/certificate/manager.go 78.42% <0.00%> (-0.04%) ⬇️
pkg/certificate/types.go 100.00% <0.00%> (ø)
pkg/configurator/mock_client_generated.go 0.00% <0.00%> (ø)
cmd/cli/version.go 43.96% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da8732...c247091. Read the comment docs.

@shashankram
Copy link
Member

@steeling this may need a rebase as I merged #4834 which also updated the values.yaml file.

@steeling steeling force-pushed the feature/permissive branch from c247091 to ad2e33f Compare June 23, 2022 14:23
@shashankram shashankram merged commit 8fd236e into openservicemesh:main Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants