This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
cli: Improved error handling #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uppercase error message edited, part of fixing openservicemesh#4524 Signed-off-by: mudit singh <[email protected]>
mudit-01
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
schristoff
approved these changes
Jun 13, 2022
|
Hi @jaellio @trstringer @nojnhuh @shashankram can I get a review on this, please. |
jaellio
approved these changes
Jun 16, 2022
shashankram
approved these changes
Jun 16, 2022
|
Thanks, @schristoff @jaellio @shashankram for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uppercase error message edited, part of fixing #4524
Signed-off-by: mudit singh [email protected]
Description:
Testing done: NA
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?