Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Remove CN from *envoy.Proxy #4773

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

steeling
Copy link
Contributor

This is part of the effort to allow rotating trust domains.

We remove the CN from the proxy struct, as that is no longer a static identifier on the proxy itself.

@steeling steeling force-pushed the feature/decouple-identity branch 7 times, most recently from e5870b5 to 5103ab4 Compare June 1, 2022 03:34
The CN is no longer static for the duration of the proxy,
and is not required to key the proxy.

Signed-off-by: Sean Teeling <[email protected]>
@steeling steeling force-pushed the feature/decouple-identity branch from 5103ab4 to 1a63975 Compare June 1, 2022 04:09
pkg/envoy/proxy_test.go Outdated Show resolved Hide resolved
pkg/metricsstore/metricsstore.go Outdated Show resolved Hide resolved
pkg/k8s/client_test.go Outdated Show resolved Hide resolved
pkg/k8s/client_test.go Show resolved Hide resolved
pkg/debugger/proxy.go Outdated Show resolved Hide resolved
pkg/k8s/types.go Show resolved Hide resolved
pkg/envoy/ads/stream.go Show resolved Hide resolved
pkg/envoy/registry/registry_test.go Outdated Show resolved Hide resolved
pkg/envoy/registry/services.go Outdated Show resolved Hide resolved
pkg/envoy/ads/stream_test.go Outdated Show resolved Hide resolved
pkg/envoy/registry/announcement_handlers.go Outdated Show resolved Hide resolved
pkg/envoy/registry/registry.go Outdated Show resolved Hide resolved
pkg/k8s/client.go Outdated Show resolved Hide resolved
Signed-off-by: Sean Teeling <[email protected]>
@steeling steeling force-pushed the feature/decouple-identity branch from 1fa990a to bfdfc9b Compare June 1, 2022 18:31
Signed-off-by: Sean Teeling <[email protected]>
@steeling steeling force-pushed the feature/decouple-identity branch from 2511ea2 to 6978122 Compare June 1, 2022 19:17
@steeling steeling force-pushed the feature/decouple-identity branch from d27c767 to 944ecbb Compare June 1, 2022 22:59
@steeling steeling force-pushed the feature/decouple-identity branch 2 times, most recently from 97980ce to 694c659 Compare June 2, 2022 00:18
@steeling steeling force-pushed the feature/decouple-identity branch from 694c659 to a795691 Compare June 2, 2022 03:10
Signed-off-by: Sean Teeling <[email protected]>
@steeling steeling force-pushed the feature/decouple-identity branch from a795691 to fa34b3c Compare June 2, 2022 04:16
@codecov-commenter
Copy link

Codecov Report

Merging #4773 (fa34b3c) into main (ae53c47) will decrease coverage by 0.18%.
The diff coverage is 46.56%.

@@            Coverage Diff             @@
##             main    #4773      +/-   ##
==========================================
- Coverage   69.04%   68.86%   -0.19%     
==========================================
  Files         225      223       -2     
  Lines       16365    16362       -3     
==========================================
- Hits        11300    11268      -32     
- Misses       5013     5042      +29     
  Partials       52       52              
Flag Coverage Δ
unittests 68.86% <46.56%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/debugger/proxy.go 2.66% <0.00%> (-7.34%) ⬇️
pkg/envoy/ads/jobs.go 0.00% <0.00%> (ø)
pkg/envoy/rds/response.go 82.85% <0.00%> (ø)
pkg/envoy/xdsutil.go 96.07% <ø> (+2.16%) ⬆️
pkg/errcode/errcode.go 100.00% <ø> (ø)
pkg/k8s/mock_controller_generated.go 14.14% <0.00%> (-1.42%) ⬇️
pkg/k8s/types.go 100.00% <ø> (ø)
pkg/workerpool/workerpool.go 100.00% <ø> (ø)
pkg/envoy/ads/cache_stream.go 22.80% <33.33%> (-9.51%) ⬇️
pkg/envoy/ads/response.go 70.73% <33.33%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae53c47...fa34b3c. Read the comment docs.

@steeling steeling marked this pull request as draft June 2, 2022 16:11
pkg/identity/types.go Outdated Show resolved Hide resolved
pkg/envoy/ads/stream.go Outdated Show resolved Hide resolved
pkg/envoy/proxy.go Outdated Show resolved Hide resolved
pkg/envoy/ads/profile.go Outdated Show resolved Hide resolved
Signed-off-by: Sean Teeling <[email protected]>
@steeling steeling marked this pull request as ready for review June 3, 2022 16:19
Signed-off-by: Sean Teeling <[email protected]>
@steeling steeling force-pushed the feature/decouple-identity branch from 8648969 to efb5420 Compare June 6, 2022 15:45
@jaellio jaellio merged commit c318b68 into openservicemesh:main Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants