This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 276
Remove CN from *envoy.Proxy #4773
Merged
jaellio
merged 11 commits into
openservicemesh:main
from
steeling:feature/decouple-identity
Jun 7, 2022
Merged
Remove CN from *envoy.Proxy #4773
jaellio
merged 11 commits into
openservicemesh:main
from
steeling:feature/decouple-identity
Jun 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Teeling <[email protected]>
Signed-off-by: Sean Teeling <[email protected]>
steeling
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
May 31, 2022 19:25
steeling
force-pushed
the
feature/decouple-identity
branch
7 times, most recently
from
June 1, 2022 03:34
e5870b5
to
5103ab4
Compare
The CN is no longer static for the duration of the proxy, and is not required to key the proxy. Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 1, 2022 04:09
5103ab4
to
1a63975
Compare
nojnhuh
reviewed
Jun 1, 2022
shashankram
reviewed
Jun 1, 2022
Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 1, 2022 18:31
1fa990a
to
bfdfc9b
Compare
Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 1, 2022 19:17
2511ea2
to
6978122
Compare
jaellio
reviewed
Jun 1, 2022
Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 1, 2022 22:59
d27c767
to
944ecbb
Compare
Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
2 times, most recently
from
June 2, 2022 00:18
97980ce
to
694c659
Compare
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 2, 2022 03:10
694c659
to
a795691
Compare
Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 2, 2022 04:16
a795691
to
fa34b3c
Compare
Codecov Report
@@ Coverage Diff @@
## main #4773 +/- ##
==========================================
- Coverage 69.04% 68.86% -0.19%
==========================================
Files 225 223 -2
Lines 16365 16362 -3
==========================================
- Hits 11300 11268 -32
- Misses 5013 5042 +29
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
reviewed
Jun 2, 2022
jaellio
reviewed
Jun 2, 2022
jaellio
reviewed
Jun 2, 2022
jaellio
reviewed
Jun 2, 2022
Signed-off-by: Sean Teeling <[email protected]>
nojnhuh
approved these changes
Jun 3, 2022
Signed-off-by: Sean Teeling <[email protected]>
steeling
force-pushed
the
feature/decouple-identity
branch
from
June 6, 2022 15:45
8648969
to
efb5420
Compare
jaellio
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort to allow rotating trust domains.
We remove the CN from the proxy struct, as that is no longer a static identifier on the proxy itself.