This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
cli/verifier: derive appProtocol from service #4691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the same mechanism as the controller to derive the app protocol for a service port. This is required for a service with multiple ports, both serving different protocols. The `AppProtocol` in the `TrafficAttribute` struct will be used for ingress/egress instead. Part of openservicemesh#4634 Signed-off-by: Shashank Ram <[email protected]>
shashankram
requested review from
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
nojnhuh
approved these changes
Apr 25, 2022
keithmattix
reviewed
Apr 25, 2022
| routeConfig := &xds_route.RouteConfiguration{} | ||
| //nolint: errcheck | ||
| //#nosec G104: Errors unhandled | ||
| r.GetRouteConfig().UnmarshalTo(routeConfig) |
There was a problem hiding this comment.
Why not check the error here and return an unknown result?
There was a problem hiding this comment.
I couldn't find a scenario where the unmarshaling fails. Wanted to avoid unnecessary checks around this if we can't test it.
jaellio
approved these changes
Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses the same mechanism as the controller to derive
the app protocol for a service port. This is required
for a service with multiple ports, both serving
different protocols.
The
AppProtocolin theTrafficAttributestructwill be used for ingress/egress instead.
Part of #4634
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
noHas documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
n/a