This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Revert "config/meshConfig: New localProxyMode field" #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithmattix
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
…4671)" This reverts commit 966405b. Signed-off-by: Keith Mattix II <[email protected]>
shashankram
approved these changes
Apr 22, 2022
keithmattix
force-pushed
the
revert-4671-feature/proxyMode-in-meshconfig
branch
from
aa571f8 to
501a226
Compare
nojnhuh
approved these changes
Apr 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #4684 +/- ##
==========================================
- Coverage 69.49% 69.44% -0.05%
==========================================
Files 217 217
Lines 15325 15287 -38
==========================================
- Hits 10650 10616 -34
+ Misses 4625 4621 -4
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Jon Huhn <[email protected]> # Conflicts: # pkg/gen/client/config/clientset/versioned/clientset.go # pkg/gen/client/config/clientset/versioned/typed/config/v1alpha3/config_client.go # pkg/gen/client/config/clientset/versioned/typed/config/v1alpha3/fake/fake_meshconfig.go # pkg/gen/client/config/clientset/versioned/typed/config/v1alpha3/fake/fake_multiclusterservice.go
keithmattix
added a commit
to keithmattix/osm
that referenced
this pull request
May 3, 2022
…4671)" (openservicemesh#4684) This reverts commit 966405b. Signed-off-by: Keith Mattix II <[email protected]> Co-authored-by: Jon Huhn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4671. We won't be creating a new API version due to guidance from k8s api conventions