Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selection UI with EUISelectable + EUIFieldSearch #40

Closed
3 tasks
Tracked by #16
KrooshalUX opened this issue Oct 5, 2022 · 2 comments
Closed
3 tasks
Tracked by #16

Update selection UI with EUISelectable + EUIFieldSearch #40

KrooshalUX opened this issue Oct 5, 2022 · 2 comments

Comments

@KrooshalUX
Copy link

KrooshalUX commented Oct 5, 2022

Created a hybrid approach for release speed and somewhat improved user experience. Marking for improvement in 2.5 release.

  • Use EUISelectable to allow user to find existing data sources.
  • Use EUIFieldSearch to allow users to search for an existing data source
  • If no external data source connections have been made, disable the radio button and have Default selected by default OR present a button for creation, which should open in a new tab.

image

image

@KrooshalUX KrooshalUX changed the title Replace radio button UI with EUISelectable + EUIFieldSearch Update selection UI with EUISelectable + EUIFieldSearch Oct 5, 2022
@KrooshalUX
Copy link
Author

For speed I imagine the best approach for the case where there are no external data source connections set up is to disable the radio button like this:

image

An alternative which we can do in 2.5 is this, which will aid in the discovery and possible adoption of the (production ready version) feature while helping build the mental model of external data sources and index patterns:

image
image

@kristenTian
Copy link

Disabling the option with the fast approach might cause confusion on why it's being disabled.

Here is the selectable with no content existing, it is also straightforward that user has none configured:

image

zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this issue Oct 11, 2022
zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this issue Oct 11, 2022
zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this issue Oct 12, 2022
zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this issue Oct 12, 2022
zhongnansu pushed a commit to zhongnansu/OpenSearch-Dashboards that referenced this issue Oct 12, 2022
)

Issue Resolved:
opensearch-project/ux#40

Signed-off-by: Kristen Tian <[email protected]>
(cherry picked from commit ac07159)
Signed-off-by: Su <[email protected]>
kristenTian added a commit to opensearch-project/OpenSearch-Dashboards that referenced this issue Oct 12, 2022
Issue Resolved:
opensearch-project/ux#40

Signed-off-by: Kristen Tian <[email protected]>
(cherry picked from commit ac07159)
Signed-off-by: Su <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Kristen Tian <[email protected]>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this issue Dec 1, 2022
) (opensearch-project#2552)

Issue Resolved:
opensearch-project/ux#40

Signed-off-by: Kristen Tian <[email protected]>
(cherry picked from commit ac07159)
Signed-off-by: Su <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Kristen Tian <[email protected]>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this issue Dec 1, 2022
) (opensearch-project#2552)

Issue Resolved:
opensearch-project/ux#40

Signed-off-by: Kristen Tian <[email protected]>
(cherry picked from commit ac07159)
Signed-off-by: Su <[email protected]>

Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Su <[email protected]>
Co-authored-by: Kristen Tian <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this issue Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants