Bump github.com/hashicorp/go-getter to 1.6.1 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rishabh6788, We should test the go run and build with the new version added, I dont see a readme to do that, @phillbaker can you please add your thoughts. |
rishabh6788
force-pushed
the
main
branch
2 times, most recently
from
5af625b to
0c9c78b
Compare
Signed-off-by: Rishabh Singh <[email protected]>
|
@prudhvigodithi +1 on the documentation around building, testing and using the repo. |
|
If the test workflows on GitHub actions complete successfully, then it
confirms the go build is succeeding. If everything is green, you should be
good to go.
…On Thu, Dec 15, 2022 at 4:20 PM Rishabh Singh ***@***.***> wrote:
@prudhvigodithi <https://github.com/prudhvigodithi> +1 on the
documentation around building, testing and using the repo.
Also, the test workflow have run successfully, aren't they sufficient to
confirm the changes don't break anything?
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKK5LKGBAMISN3XMTS3WNODQPANCNFSM6AAAAAATADROFY>
.
You are receiving this because you were mentioned.Message ID:
<opensearch-project/terraform-provider-opensearch/pull/10/c1353720561@
github.com>
|
|
Hey @phillbaker I can see all the workflows are successful, good to merge? |
|
Go for it!
…On Thu, Jan 5, 2023 at 5:44 PM Prudhvi Godithi ***@***.***> wrote:
Hey @phillbaker <https://github.com/phillbaker> I can see all the
workflows are successful, good to merge?
Thank you
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKNBZ43CN4AJGBHWTBDWQ5FDBANCNFSM6AAAAAATADROFY>
.
You are receiving this because you were mentioned.Message ID:
<opensearch-project/terraform-provider-opensearch/pull/10/c1372886285@
github.com>
|
prudhvigodithi
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishabh Singh [email protected]
Description
Bump github.com/hashicorp/go-getter to 1.6.1.
Issues Resolved
https://github.com/opensearch-project/terraform-provider-opensearch/security/dependabot/4
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.