Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jetty Dependency #872

Conversation

forestmvey
Copy link
Collaborator

Description

Update Jetty Dependency, wiremock dependency and fixes for associated errors. Upgrade necessary to fix jetty dependency CVE.

Related Issue

wiremock/1944

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@forestmvey forestmvey requested a review from a team as a code owner September 29, 2022 22:50
@codecov-commenter
Copy link

Codecov Report

Merging #872 (1cf8411) into 2.x (10e44ee) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #872      +/-   ##
============================================
+ Coverage     94.93%   94.97%   +0.04%     
- Complexity     2973     2989      +16     
============================================
  Files           291      291              
  Lines          7949     8015      +66     
  Branches        579      586       +7     
============================================
+ Hits           7546     7612      +66     
  Misses          349      349              
  Partials         54       54              
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <0.00%> (ø)
...n/java/org/opensearch/sql/utils/DateTimeUtils.java 100.00% <0.00%> (ø)
...a/org/opensearch/sql/utils/DateTimeFormatters.java 100.00% <0.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <0.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the dependencies Pull requests that update a dependency file label Sep 29, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! May need to backport to main branch later.

@dai-chen dai-chen added the JDBC label Sep 29, 2022
@joshuali925 joshuali925 merged commit 91abe43 into opensearch-project:2.x Sep 29, 2022
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 3, 2022
GabeFernandez310 pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the integ-update-jdbc-jetty-dependency branch January 4, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants