Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BWC tests with with OpenSearch 1.1 #772

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

closes #733

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner August 17, 2022 18:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #772 (3407fdb) into main (ce15448) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #772   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity     2913     2913           
=========================================
  Files           288      288           
  Lines          7839     7839           
  Branches        571      571           
=========================================
  Hits           7436     7436           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@joshuali925 joshuali925 merged commit eeb90cf into opensearch-project:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Restore bcw tests
4 participants