Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule request in worker thread #748

Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Aug 12, 2022

Signed-off-by: penghuo [email protected]

Description

  • Schedule request in worker thread.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner August 12, 2022 00:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #748 (2076106) into main (6fb3fac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #748   +/-   ##
=========================================
  Coverage     94.78%   94.79%           
- Complexity     2880     2883    +3     
=========================================
  Files           286      287    +1     
  Lines          7735     7743    +8     
  Branches        565      565           
=========================================
+ Hits           7332     7340    +8     
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.76% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/sql/opensearch/executor/Scheduler.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dai-chen
dai-chen previously approved these changes Aug 12, 2022
joshuali925
joshuali925 previously approved these changes Aug 12, 2022
@penghuo penghuo dismissed stale reviews from joshuali925 and dai-chen via e86b308 August 16, 2022 16:32
@penghuo penghuo force-pushed the scheduleRequestInWorkerThread branch from 2076106 to e86b308 Compare August 16, 2022 16:32
@joshuali925
Copy link
Member

just curious, why do we force push to squash commits like this? i felt reviewing is more difficult since I had to compare 2076106 and e86b308 to figure out what has changed, or is there a better way?

@penghuo penghuo merged commit ce15448 into opensearch-project:main Aug 17, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-748-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce15448fbd005931b4a7272a643e2d076334ee63
# Push it to GitHub
git push --set-upstream origin backport/backport-748-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-748-to-2.x.

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Nov 1, 2022
6 tasks
@jduo jduo mentioned this pull request Oct 29, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants