Refactor implementation of relevance queries #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #746 +/- ##
============================================
- Coverage 94.78% 94.76% -0.03%
- Complexity 2880 2884 +4
============================================
Files 286 289 +3
Lines 7735 7699 -36
Branches 565 562 -3
============================================
- Hits 7332 7296 -36
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Outdated
Show resolved
Hide resolved
joshuali925
reviewed
Aug 16, 2022
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Show resolved
Hide resolved
- Update QueryStringTest to check for SyntaxCheckException. SyntaxCheckException is correct when incorrect # of parameters See opensearch-project#604 (comment) for reference. - Introduce MultiFieldQuery and SingleFieldQuery base classes. - Extract FunctionResolver interface. FunctionResolver is now DefaultFunctionResolver. RelevanceFunctionResolver is a simplified function resolver for relevance search functions. - Removed tests from FilterQueryBuilderTest that verified exceptions thrown for invalid function calls. These scenarios are now handled by RelevanceQuery::build. Signed-off-by: MaxKsyunz <[email protected]>
MaxKsyunz
force-pushed
the
integ-textsearch-improvements
branch
from
0f13069 to
e76dc6e
Compare
6 tasks
Yury-Fridlyand
approved these changes
Aug 22, 2022
forestmvey
approved these changes
Aug 22, 2022
MitchellGale
approved these changes
Aug 22, 2022
penghuo
reviewed
Aug 29, 2022
core/src/main/java/org/opensearch/sql/expression/function/OpenSearchFunctions.java
Show resolved
Hide resolved
This was referenced Aug 30, 2022
penghuo
approved these changes
Sep 7, 2022
joshuali925
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SemanticCheckExceptionfromRelevanceQuery::buildif a parameter is specified more than once. Combined with (1), the end user gets a much better error message.MultiFieldQueryandSingleFieldQuery. This allowed for cleaner code in derived classes.MultiMatchQueryandQueryStringQuery. These functions now throw aSyntaxCheckExceptionif called with insufficient number of parameters. This is in line with other query functions.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.