-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPL describe command #646
Merged
Merged
PPL describe command #646
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9924c17
change pplStatement to searchStatement
seankao-az 7f3bba2
parse describe (tmp: but execute search)
seankao-az 8c608f6
support describe command and piping; wrong types
seankao-az 0f1027e
fix import wildcard
seankao-az 5c282b4
indentation fix
seankao-az 36aed7a
remove fromMetaClause
seankao-az e07a75d
remove redundant code
seankao-az 3994499
remove unused import
seankao-az 9ef52d1
fix format mismatch with sql (breaking change?)
seankao-az dd6f87e
unit test
seankao-az a0a65cb
revert protocol-breaking change
seankao-az 1fd9024
allow expression as index identifiers
seankao-az 6107b4b
integ test
seankao-az bdf3703
user doc for ppl describe
seankao-az 633250d
support comma, need change in index name validity:
seankao-az d4dd52f
add example with condition and filter in doc
seankao-az 8ce1187
support multiple indices
seankao-az 3c537d0
Support multiple comma separated indices
seankao-az 7f8e9d8
remove redundancy
seankao-az 7e228ac
merge table source parsing for search and describe
seankao-az File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
unit test
Signed-off-by: Sean Kao <seankao@amazon.com>
- Loading branch information
commit dd6f87e8e21b42213e0146c14458f8dc28ebfd09
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for this example? It seems little odd because if someone wants a,b as result he would specify a,b instead of describing table and filtering again.
Fields command is to project menitoned columns from the result set. A plausible usecase could be describe t | fields 2, 3 which implies give me second and third column names.
Also if someone appends other commands to describe, what is the expected behavior. I am assuming we will be calculating on the result set provided by prior describe command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct. When appending other commands to describe, the behavior is to query the metadata table, instead of the data table itself (as expected for the pipe syntax).
An example of the usage of
fields
can be seen hereThe fields do not refer to the data table's fields, but the metadata table's fields, because the result set of the describe command is a metadata table. Here you can see the full list of such fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, we could support that using the following syntax:
However, it doesn't quite work yet at the moment, due to type mismatch snippet 1, snippet 2. Also, most of the metadata are meaningless right now, including the order of the columns.