Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Query Unit Tests #614

Merged

Conversation

forestmvey
Copy link
Collaborator

Description

Add unit tests for match function implementation with 100% code coverage.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

forestmvey and others added 7 commits May 13, 2022 12:52
… avoid NoSuchElementException in MatchQuery

Signed-off-by: forestmvey <[email protected]>
…ng exceptions and moved private method definition placement below public methods

Signed-off-by: forestmvey <[email protected]>
… Fixed checkstyle syntax errors.

Signed-off-by: forestmvey <[email protected]>
@forestmvey forestmvey requested a review from a team as a code owner May 18, 2022 18:58
@codecov-commenter
Copy link

Codecov Report

Merging #614 (d2184f8) into main (a7d4395) will decrease coverage by 31.82%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #614       +/-   ##
=============================================
- Coverage     94.59%   62.76%   -31.83%     
=============================================
  Files           276       10      -266     
  Lines          7455      658     -6797     
  Branches        551      119      -432     
=============================================
- Hits           7052      413     -6639     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...age/script/filter/lucene/relevance/MatchQuery.java
...search/response/agg/NoBucketAggregationParser.java
...rg/opensearch/sql/ppl/domain/PPLQueryResponse.java
...arch/storage/system/OpenSearchSystemIndexScan.java
...l/opensearch/setting/LegacyOpenDistroSettings.java
...ch/request/system/OpenSearchCatIndicesRequest.java
.../opensearch/monitor/OpenSearchResourceMonitor.java
.../opensearch/sql/expression/FunctionExpression.java
...esponse/format/VisualizationResponseFormatter.java
...ch/planner/logical/rule/MergeSortAndIndexScan.java
... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d4395...d2184f8. Read the comment docs.

@joshuali925 joshuali925 merged commit 760e377 into opensearch-project:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants