-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match Query Unit Tests #614
Merged
joshuali925
merged 7 commits into
opensearch-project:main
from
Bit-Quill:integ-match_query_unit_tests
May 19, 2022
Merged
Match Query Unit Tests #614
joshuali925
merged 7 commits into
opensearch-project:main
from
Bit-Quill:integ-match_query_unit_tests
May 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid NoSuchElementException in MatchQuery Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
…ng exceptions and moved private method definition placement below public methods Signed-off-by: forestmvey <[email protected]>
… Fixed checkstyle syntax errors. Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Adding Match Query Unit Tests
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=============================================
- Coverage 94.59% 62.76% -31.83%
=============================================
Files 276 10 -266
Lines 7455 658 -6797
Branches 551 119 -432
=============================================
- Hits 7052 413 -6639
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
joshuali925
approved these changes
May 19, 2022
dai-chen
approved these changes
May 19, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for match function implementation with 100% code coverage.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.