Version 2.0 #507

vmmusings · 2022-03-22T05:14:25Z

Description

This PR Covers the following items.

Version 2.0 bump
Gradle 7 Upgrade
JDK 8 removal
Handled removal of mapping types in SQL Plugin.

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov-commenter · 2022-03-23T04:04:39Z

Codecov Report

Merging #507 (5801a1d) into main (2050899) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #507      +/-   ##
============================================
- Coverage     95.25%   95.24%   -0.01%     
+ Complexity     2746     2744       -2     
============================================
  Files           276      276              
  Lines          7416     7410       -6     
  Branches        544      537       -7     
============================================
- Hits           7064     7058       -6     
  Misses          298      298              
  Partials         54       54

Flag	Coverage Δ
query-workbench	`62.91% <ø> (ø)`
sql-engine	`98.40% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java	`100.00% <100.00%> (ø)`
.../opensearch/sql/planner/physical/SortOperator.java	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2050899...5801a1d. Read the comment docs.

Signed-off-by: vamsi-amazon <[email protected]>

penghuo · 2022-03-23T23:17:49Z

buildSrc/build.gradle

+    mavenCentral()
+}
+
+dependencies {


does this change is required by all plugin? if so, could you add related issue/pr.

We are using a third party plugin to spawn and kill process in doctest module. The plugin is around 5 years old and there is no active development. As part of Gradle 7 upgrade spawn plugin is throwing errors. As part of fix, imported the plugin code to buildSrc and upgraded to Gradle 7.[The only way for upgrading unmaintained third party plugins]. I couldn't find another well maintained plugin to replace.

#303. Will add to the description.

thanks. could we create an issue to tracking move this dependency later. ideally, we should not depend on it.

penghuo

Could you add some comments that why tests in integ-test/doctest are deleted. If it is for deprecate legacy not used test, I would prefer to have a separated PR .

penghuo

Please also help revert change introduce in #483. We could do it separately.

joshuali925 · 2022-03-23T23:23:24Z

buildSrc/src/main/groovy/com/wiredforcode/spawn/KillProcessTask.groovy

+
+import org.gradle.api.tasks.TaskAction
+
+class KillProcessTask extends DefaultSpawnTask {


what is this for?

#507 (comment)

Commented here.

gradle/wrapper/gradle-wrapper.properties

gradlew

vmmusings · 2022-03-23T23:44:02Z

Could you add some comments that why tests in integ-test/doctest are deleted. If it is for deprecate legacy not used test, I would prefer to have a separated PR .

@penghuo It was deleted after consulting with @dai-chen. The reason to remove them in this CR is when we are bumping to 2.0, these files are causing build issues with breaking changes from upstream libraries. I felt the better way to handle is to remove them in this CR itself.

Signed-off-by: vamsi-amazon <[email protected]>

dai-chen · 2022-03-24T17:26:42Z

Could you add some comments that why tests in integ-test/doctest are deleted. If it is for deprecate legacy not used test, I would prefer to have a separated PR .

@penghuo It was deleted after consulting with @dai-chen. The reason to remove them in this CR is when we are bumping to 2.0, these files are causing build issues with breaking changes from upstream libraries. I felt the better way to handle is to remove them in this CR itself.

yeah, the doctest package is Java code that generates the docs initially. It is not used any more and should be safe to delete.

penghuo

Thanks for the change!

dai-chen

Thanks for the changes!

…ject#655. Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

." This reverts commit 162b79e.

vmmusings marked this pull request as ready for review March 22, 2022 18:01

vmmusings requested a review from a team as a code owner March 22, 2022 18:01

vmmusings marked this pull request as draft March 22, 2022 18:01

vmmusings force-pushed the version-2.0 branch from 2d15db5 to b37bb8f Compare March 23, 2022 09:58

Version Bump 2.0

45238ad

Signed-off-by: vamsi-amazon <[email protected]>

vmmusings force-pushed the version-2.0 branch from e4b1236 to 45238ad Compare March 23, 2022 21:22

vmmusings marked this pull request as ready for review March 23, 2022 21:50

vmmusings requested review from dai-chen, joshuali925 and penghuo March 23, 2022 21:50

penghuo reviewed Mar 23, 2022

View reviewed changes

joshuali925 reviewed Mar 23, 2022

View reviewed changes

Added License headers to code

5801a1d

Signed-off-by: vamsi-amazon <[email protected]>

vmmusings force-pushed the version-2.0 branch from 8074e90 to 5801a1d Compare March 24, 2022 00:03

penghuo approved these changes Mar 24, 2022

View reviewed changes

dai-chen approved these changes Mar 24, 2022

View reviewed changes

vmmusings merged commit 6771968 into opensearch-project:main Mar 24, 2022

Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 5, 2022

Backport gradle update from opensearch-project#507 and opensearch-pro…

66766c6

…ject#655. Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 5, 2022

Backport gradle project files update from opensearch-project#507.

162b79e

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 5, 2022

Revert "Backport gradle project files update from opensearch-project#507

b8b04e3

." This reverts commit 162b79e.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 2.0 #507

Version 2.0 #507

vmmusings commented Mar 22, 2022 •

edited

Loading

codecov-commenter commented Mar 23, 2022 •

edited

Loading

penghuo Mar 23, 2022

vmmusings Mar 23, 2022

vmmusings Mar 23, 2022

penghuo Mar 24, 2022

penghuo left a comment

penghuo left a comment

joshuali925 Mar 23, 2022

vmmusings Mar 23, 2022

vmmusings commented Mar 23, 2022

dai-chen commented Mar 24, 2022

penghuo left a comment

dai-chen left a comment


		import org.gradle.api.tasks.TaskAction

		class KillProcessTask extends DefaultSpawnTask {

Version 2.0 #507

Version 2.0 #507

Conversation

vmmusings commented Mar 22, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Mar 23, 2022 • edited Loading

Codecov Report

penghuo Mar 23, 2022

Choose a reason for hiding this comment

vmmusings Mar 23, 2022

Choose a reason for hiding this comment

vmmusings Mar 23, 2022

Choose a reason for hiding this comment

penghuo Mar 24, 2022

Choose a reason for hiding this comment

penghuo left a comment

Choose a reason for hiding this comment

penghuo left a comment

Choose a reason for hiding this comment

joshuali925 Mar 23, 2022

Choose a reason for hiding this comment

vmmusings Mar 23, 2022

Choose a reason for hiding this comment

vmmusings commented Mar 23, 2022

dai-chen commented Mar 24, 2022

penghuo left a comment

Choose a reason for hiding this comment

dai-chen left a comment

Choose a reason for hiding this comment

vmmusings commented Mar 22, 2022 •

edited

Loading

codecov-commenter commented Mar 23, 2022 •

edited

Loading