Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Constant Fields as final #3191

Conversation

currantw
Copy link
Contributor

@currantw currantw commented Dec 5, 2024

Description

Cleanup Only - Mark Constant Fields as final

Related Issues

None

Check List

  • N/A - New functionality includes testing.
  • N/A - New functionality has been documented.
  • N/A - New functionality has javadoc added.
  • N/A - New functionality has a user manual doc added.
  • N/A - API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • N/A - Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@YANG-DB
Copy link
Member

YANG-DB commented Dec 5, 2024

@currantw thanks for splitting the cleanup process
can you also add a central (RFC) github issue with steps for all the cleanup phases (sub-issues) so we can have a better picture of the expected changes ?

@currantw
Copy link
Contributor Author

currantw commented Dec 5, 2024

@currantw thanks for splitting the cleanup process can you also add a central (RFC) github issue with steps for all the cleanup phases (sub-issues) so we can have a better picture of the expected changes ?

Good idea @YANG-DB. I have raised #3194.

@acarbonetto acarbonetto merged commit bc2fd58 into opensearch-project:main Dec 6, 2024
14 of 15 checks passed
@acarbonetto acarbonetto deleted the opensearch-sql-3145_cleanup_final branch December 6, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants