Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport] Fix: CSV and Raw output, escape quotes #3148

Merged

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Nov 6, 2024

Description

Manual backport of #3063 due to merge conflicts

Related Issues

Resolves #3050

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

* Add failing tests

Signed-off-by: Simeon Widdis <[email protected]>

* Fix the first test

Signed-off-by: Simeon Widdis <[email protected]>

* Revise the tests

Signed-off-by: Simeon Widdis <[email protected]>

* Fix wildcard tests

Signed-off-by: Simeon Widdis <[email protected]>

* Add license header

Signed-off-by: Simeon Widdis <[email protected]>

* Fix rerunning SQL parsing

Signed-off-by: Simeon Widdis <[email protected]>

---------

Signed-off-by: Simeon Widdis <[email protected]>
Fixes opensearch-project#3050

Signed-off-by: Mike Swierczek <[email protected]>
(cherry picked from commit cfe38d7)
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis force-pushed the backport/backport-3063-to-2.x branch from 1e87ec7 to 9480b7f Compare November 6, 2024 22:11
Swiddis and others added 2 commits November 6, 2024 14:12
@ykmr1224 ykmr1224 merged commit ce6086b into opensearch-project:2.x Nov 14, 2024
16 of 26 checks passed
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Nov 14, 2024
ykmr1224 added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CSV output doesn't handle entries with quotes but not commas.
4 participants