Updating JobExecutionResponseReader interface to add RequestContext #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amityadav005
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
ykmr1224
reviewed
Oct 10, 2024
noCharger
reviewed
Oct 10, 2024
Signed-off-by: AMIT YADAV <[email protected]>
amityadav005
force-pushed
the
response_reader_interface_changes
branch
from
2024867 to
60dd109
Compare
Signed-off-by: AMIT YADAV <[email protected]>
amityadav005
force-pushed
the
response_reader_interface_changes
branch
from
60dd109 to
fccc556
Compare
noCharger
approved these changes
Oct 15, 2024
ykmr1224
approved these changes
Oct 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
…3062) * Updating JobExecutionResponseReader interface to add RequestContext Signed-off-by: AMIT YADAV <[email protected]> * Updating JobExecutionResponseReader interface to add RequestContext Signed-off-by: AMIT YADAV <[email protected]> --------- Signed-off-by: AMIT YADAV <[email protected]> Co-authored-by: AMIT YADAV <[email protected]> (cherry picked from commit 7666a44) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JSONObject getResultWithJobId(String jobId, String resultLocation)togetResultFromResultIndex( AsyncQueryJobMetadata asyncQueryJobMetadata, AsyncQueryRequestContext asyncQueryRequestContext)Related Issues
Resolves #[Issue number to be closed when this PR is merged]
na
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.