-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doctest code for more consistent runs #3053
Update doctest code for more consistent runs #3053
Conversation
Signed-off-by: Simeon Widdis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the changes to 2.x and looked at the failures: those failures actually seem related to this PR: updating a specific dependency of |
Signed-off-by: Simeon Widdis <[email protected]>
So, it turns out that this formatting change affects a lot of tables. I automated refactoring all of them and verified it passes |
Signed-off-by: Simeon Widdis <[email protected]>
f935487
to
7caaff6
Compare
Test failures related to #3056, waiting to merge that |
Gradle build is passing as advertised, BWC seems to have unrelated issues (would it be worthwhile to split gradle/bwc tests into separate actions?) |
|
||
If the passed response is not an _explain response, the input is left unmodified. | ||
""" | ||
def normalize_explain_response(data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems all query reponse are impacted, not only the explain query. do u know why the format is different? does it impact rest api customer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting changes because of cli-helpers
updating from v1 to v2 in sql-cli
, which removes some extra whitespace from most responses. It's separate from the _explain
issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3053-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cf1564b6aeb03e49f19032d14bf69d51d6332984
# Push it to GitHub
git push --set-upstream origin backport/backport-3053-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swiddis should this backport to 2.x?
Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit cf1564b)
* Update doctest code for more consistent runs Signed-off-by: Simeon Widdis <[email protected]> * Update doctest code for more consistent runs (#3053) Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit cf1564b) * Fix doctests Signed-off-by: Simeon Widdis <[email protected]> * Fix MalformedqueryIT Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
Description
Doctest seems to be failing locally because of updates with
needClean
orpitId
fields being included in_explain
requests, but when trying to update the test cases to account for this, they start failing again as the field list changes more. This PR adds a normalization step to get these tests to behave more consistently.Related Issues
Resolves #3048
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.